WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] use per-cpu variables in cpufreq

To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] use per-cpu variables in cpufreq
From: Keir Fraser <keir@xxxxxxx>
Date: Fri, 27 May 2011 14:11:51 +0100
Cc:
Delivery-date: Fri, 27 May 2011 06:14:00 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=Y2u6nzzV/un/pABxYlgaqRTv4jQwkyrn5FsuKLaQ4xM=; b=O82Xtosan5aQlyaGAIH7atlK1kifLQAycpwq7vnH/Q/8XLQpDAvplQR/FSVUSEORJM SV4BJw+PIm9dHgzCbTuLILvJh8Ivr/9KCL70EXoKL5PRKqaOeJv9pFcr1PJCeFl4AC5c tMBgPC9nP8qJb5MOJYgH5dC7tN2rdUSd+XVHU=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=ppnrh9j1rnFlUtUwZbpb5I8V/f/PWKwVPXhdgpuxCj1EIjKSgSogiiUtI/asVpOscT S4jAMvQdZIcDUa1nRufP+mup8HMpe/VUgFMINX0zsbnvFzZhDcGhz94hHAz3oaoT5gIt QXhqz9ZoAe/jbFQ+4kfsNMT4vGUjTjRqC52ms=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <eb601128d89304960076.1306494680@nehalem1>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acwcb6RHZEZzZpitvkyZ0ttfle2sYg==
Thread-topic: [Xen-devel] [PATCH] use per-cpu variables in cpufreq
User-agent: Microsoft-Entourage/12.29.0.110113
On 27/05/2011 12:11, "Juergen Gross" <juergen.gross@xxxxxxxxxxxxxx> wrote:

> The cpufreq driver used some local arrays indexed by cpu number. This patch
> replaces those arrays by per-cpu variables. The AMD and INTEL specific parts
> used different per-cpu data structures with nearly identical semantics.
> Fold the two structures into one by adding a generic architecture data item.

Xen's per-cpu data gets freed across cpu offline/online, whereas cpu-indexed
arrays of course do not. Will the cpufreq state be correctly handled across
offline/online if we switch to per-cpu vars?

 -- Keir

> Signed-off-by: juergen.gross@xxxxxxxxxxxxxx
> 
> 
> 8 files changed, 58 insertions(+), 66 deletions(-)
> xen/arch/x86/acpi/cpufreq/cpufreq.c       |   36 ++++++++++++------------
> xen/arch/x86/acpi/cpufreq/powernow.c      |   43 +++++++++++------------------
> xen/drivers/acpi/pmstat.c                 |    6 ++--
> xen/drivers/cpufreq/cpufreq.c             |   24 ++++++++--------
> xen/drivers/cpufreq/cpufreq_ondemand.c    |    2 -
> xen/drivers/cpufreq/utility.c             |    8 ++---
> xen/include/acpi/cpufreq/cpufreq.h        |    3 +-
> xen/include/acpi/cpufreq/processor_perf.h |    2 -
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel