[Xen-devel] Re: [PATCH 0 of 8] Remove static variables from xc_domain_{save, restore}.c

[Shriram Rajagopalan <rshriram@xxxxxxxxx>]

On Tue, May 24, 2011 at 5:14 AM, Ian Campbell <ian.campbell@xxxxxxxxxx> wrote:

Otherwise users which deal with multiple domains need to do their own
locking and cannot save/migrate multiple domains in parallel (should
they want to).

Also made a bunch of cleanup along the way, mainly to make it easier
to figure out what was going on with the twisty maze of macros
redefining functions as macros and redefining the macros etc. I'm sure
there is plenty more straightening out which could be done but I don't
have the stomach for it this morning.

I ll do it!!.. I have been waiting for this. Thanks a lot for cleaning up this chaff!
I was under the impression that this was some arcane legacy code that shouldnt
be touched. One particular thing that I would like to do is to factor out the write functions
(outbuf_*, noncached_write, ratewrite*, etc) into a separate file and make it sort of pluggable.

(selfish :P) I wanted to introduce a patch that would overlap outbuf flush operation
and guest memory copy operation instead of the current model <flush,copy,flush,copy..>.
This might be helpful for both Remus and live migration of large domains.

Shriram, does this have any impact on Remus?

From a cursory look, it doesnt look like it would impact Remus. I ll test it
in my setup and revert soon. 

shriram
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel