| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH 1 of 8] libxc: save/restore: remove static contex
On 05/24/2011 10:14 AM, Ian Campbell wrote:
# HG changeset patch
# User Ian Campbell<ian.campbell@xxxxxxxxxx>
# Date 1306228450 -3600
# Node ID c43bf40e2f29eb02c7dcf1a2317f243f1af5f659
# Parent 0727b2fcc33fd5cdf847fde0d2be261be3d6b279
libxc: save/restore: remove static context variables
20544:ad9d75d74bd5 and 20545:cc7d66ba0dad seemingly intended to change these
global static variables into stack variables but didn't remove the static
qualifier.
Also zero the entire struct once with memset rather than clearing fields
piecemeal in two different places.
Good catch.
Acked-by-self.
--
Vincent
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] [PATCH 0 of 8] Remove static variables from xc_domain_{save, restore}.c, Ian Campbell
- [Xen-devel] [PATCH 1 of 8] libxc: save/restore: remove static context variables, Ian Campbell
- Re: [Xen-devel] [PATCH 1 of 8] libxc: save/restore: remove static context variables,
Vincent Hanquez <=
- [Xen-devel] [PATCH 2 of 8] libxc: save: drop code under ADAPTIVE_SAVE ifdef, Ian Campbell
- [Xen-devel] [PATCH 3 of 8] libxc: save: rename ratewrite to uncached, Ian Campbell
- [Xen-devel] [PATCH 4 of 8] libxc: save: noncached write doesn't use live parameter, Ian Campbell
- [Xen-devel] [PATCH 5 of 8] libxc: save: move static "write_count" variable into outbuf, Ian Campbell
- [Xen-devel] [PATCH 7 of 8] libxc: save: don't bother calculating stat's deltas unless we are going to print them, Ian Campbell
- [Xen-devel] [PATCH 6 of 8] libxc: save: encapsulate time stats in a struct, Ian Campbell
- [Xen-devel] [PATCH 8 of 8] libxc: save: move static stats variable to stack variable, Ian Campbell
- [Xen-devel] Re: [PATCH 0 of 8] Remove static variables from xc_domain_{save, restore}.c, Shriram Rajagopalan
|
|
|
| |
|
Home