This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[PATCH] Re: [Xen-devel] pci_remove_device: fix linked list discipline

To: Jan Beulich <JBeulich@xxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>
Subject: [PATCH] Re: [Xen-devel] pci_remove_device: fix linked list discipline
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Mon, 23 May 2011 13:54:23 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 23 May 2011 05:55:10 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110523095554.GA12801@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <7b12c46b18777655c8a5.1305708795@xxxxxxxxxxxxxxxxxxxxxxx> <4DD6A7E302000078000428AA@xxxxxxxxxxxxxxxxxx> <20110523095554.GA12801@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
At 10:55 +0100 on 23 May (1306148154), Tim Deegan wrote:
> > Somehow I overlooked this patch when it was sent - looking at the
> > code it modifies I can't see why the ..._safe() variant is necessary
> > here, as there's a break statement following the list deletion.
> Ah - good point.  I'll go back to the crash report I thought this fixed
> and take another look. :)

The attached patch is a more likely candidate.  That will teach me to
debug crash reports without getting hold of proper debug symbols. :)

Keir, can you apply this and revert 23352:ea48976517af ?



Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, Xen Platform Team
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

Attachment: x
Description: Text document

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>