This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] X86: Fix a little mca bug

To: Keir Fraser <keir.xen@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] X86: Fix a little mca bug
From: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>
Date: Thu, 19 May 2011 20:03:33 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, "Dong, Eddie" <eddie.dong@xxxxxxxxx>, "Li, Xin" <xin.li@xxxxxxxxx>
Delivery-date: Thu, 19 May 2011 05:05:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwWHMbSu4Vbu56/T0OzJPao3Evrrg==
Thread-topic: [PATCH] X86: Fix a little mca bug
X86: Fix a little mca bug

At x86_mcinfo_dump(), a little bug at printk information, illusively 
indicate an CMCI/POLLED error to a MCE error, this will make debug confusing.

Signed-off-by: Liu, Jinsong <jinsong.liu@xxxxxxxxx>

diff -r 2fe45768d2c1 xen/arch/x86/cpu/mcheck/mce.c
--- a/xen/arch/x86/cpu/mcheck/mce.c     Tue May 10 13:58:21 2011 +0800
+++ b/xen/arch/x86/cpu/mcheck/mce.c     Thu May 19 15:10:07 2011 +0800
@@ -944,10 +944,11 @@ void x86_mcinfo_dump(struct mc_info *mi)
                "CPU%d: Machine Check Exception: %16"PRIx64"\n",
                mc_global->mc_coreid, mc_global->mc_gstatus);
-    } else {
-        printk(XENLOG_WARNING "MCE: The hardware reports a non "
-               "fatal, correctable incident occurred on "
-               "CPU %d.\n",
+    } else if (mc_global->mc_flags & MC_FLAG_CMCI) {
+        printk(XENLOG_WARNING "CMCI occurred on CPU %d.\n", 
+               mc_global->mc_coreid);
+    } else if (mc_global->mc_flags & MC_FLAG_POLLED) {
+        printk(XENLOG_WARNING "POLLED occurred on CPU %d.\n",

Attachment: mca-cleanup.patch
Description: mca-cleanup.patch

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>