WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] Fix save.py bug

To: Keir Fraser <keir.xen@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] Fix save.py bug
From: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>
Date: Wed, 18 May 2011 16:30:50 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "rshriram@xxxxxxxxx" <rshriram@xxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>, "Li, Xin" <xin.li@xxxxxxxxx>
Delivery-date: Wed, 18 May 2011 01:33:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcwVNeUiZD1hnDVwQtGl2pgdjcvHdg==
Thread-topic: [PATCH] Fix save.py bug
Resend it, it has been acked by Ian and Shriram, but seems to be ignored and 
didn't in unstable tree :)

Thanks,
Jinsong

================
Fix save.py bug

Fix save.py bug, to avoid compiling error under python2.4

Signed-off-by: Liu, Jinsong <jinsong.liu@xxxxxxxxx>
Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Acked-by: Shriram Rajagopalan <rshriram@xxxxxxxxx>

diff -r f9bb0bbea7c2 tools/python/xen/remus/save.py
--- a/tools/python/xen/remus/save.py    Thu May 12 16:42:54 2011 +0100
+++ b/tools/python/xen/remus/save.py    Fri May 13 22:45:21 2011 +0800
@@ -161,11 +161,12 @@ class Saver(object):
 
         self.checkpointer = xen.lowlevel.checkpoint.checkpointer()
         try:
-            self.checkpointer.open(self.vm.domid)
-            self.checkpointer.start(self.fd, self.suspendcb, self.resumecb,
-                                    self.checkpointcb, self.interval)
-        except xen.lowlevel.checkpoint.error, e:
-            raise CheckpointError(e)
+            try:
+                self.checkpointer.open(self.vm.domid)
+                self.checkpointer.start(self.fd, self.suspendcb, self.resumecb,
+                                        self.checkpointcb, self.interval)
+            except xen.lowlevel.checkpoint.error, e:
+                raise CheckpointError(e)
         finally:
             try: #errors in checkpoint close are not critical atm.
                 self.checkpointer.close()

Attachment: fix-save-py-new.patch
Description: fix-save-py-new.patch

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel