| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
RE: [Xen-devel] [PATCH] Fix save.py bug
|
To: |
Ian Campbell <Ian.Campbell@xxxxxxxxxx>, "rshriram@xxxxxxxxx" <rshriram@xxxxxxxxx> |
|
Subject: |
RE: [Xen-devel] [PATCH] Fix save.py bug |
|
From: |
"Liu, Jinsong" <jinsong.liu@xxxxxxxxx> |
|
Date: |
Sat, 14 May 2011 01:33:05 +0800 |
|
Accept-language: |
en-US |
|
Acceptlanguage: |
en-US |
|
Cc: |
Rajagopalan <rshriram@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Keir Fraser <keir.xen@xxxxxxxxx>, Shriram |
|
Delivery-date: |
Fri, 13 May 2011 10:33:50 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1305297378.31488.132.camel@xxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<BC00F5384FCFC9499AF06F92E8B78A9E2076373075@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <1305297378.31488.132.camel@xxxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
AcwReyLdF+mKRet5TiiOhNDg+h2J7AAF8wPg |
|
Thread-topic: |
[Xen-devel] [PATCH] Fix save.py bug |
Ian Campbell wrote:
> Adding Remus maintainer. You can consult the MAINTAINERS file at the
> top level to fix this.
>
> On Fri, 2011-05-13 at 15:26 +0100, Liu, Jinsong wrote:
>> I don't know python well, but when I compile at my platform, compile
>> error as:
>>
>>
>> =======================
>> ...
>> Parsing libxl.idl
>> cmp: _libxl_paths.h.tmp: No such file or directory
>> cmp: _libxl_paths.h: No such file or directory
>> cmp: xen/util/path.py: No such file or directory
>> Parsing
>>
>>
>> /otc/source/vtd/xen-unstable/tools/python/../../tools/libxl/libxl.idl
>> File "/usr/lib64/python2.4/site-packages/xen/remus/save.py", line
>> 169 finally: ^
>> SyntaxError: invalid syntax
>> ...
>>
>> ======================
>>
>>
>> This kind of compile error introduced from c/s 23195.
>> This patch revert it.
>
> That seems rather extreme in the first instance.
>
> From a quick google It seems that python 2.4 did not properly support
> the "try: ... except: ... finally: ... " syntax. It appears that as a
> workaround one can do
> try:
> try:
> ...
> except:
> ...
> finally:
> ...
>
> But I didn't try this myself.
>
> Ian.
Shriram and Ian,
I update the patch according to Ian's comments, as attached.
Test result shows compiling OK now.
Thanks,
Jinsong
fix-save-py-new.patch
Description: fix-save-py-new.patch
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home