Re: [Xen-devel] [GIT PULL] for-2.6.32/bug-fixes

>>> Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 05/17/11 6:44 PM >>>
>On Tue, May 17, 2011 at 05:24:43PM +0100, Jan Beulich wrote:
>> >>> On 17.05.11 at 17:57, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
>> >> > No attaching of data to the barrier.
>> >>
>> >> Sure, this direction we agree about. But your change is enforcing
>> >> it the other way around (if barrier then no data), which wasn't the
>> >> case so far.
>> >
>> > OK, even if the code that actually does the bio submission does
>> > not attach any data to the bio? The end result is the same - no
>> > data with barriers.
>>
>> My problem is that I can't see where attaching data would be
>> skipped. The only thing I see is the BUG_ON() you pointed at
>
>Well, req->ns_segments = 0, so nseg is zero, which means all
>of those for loops never get executed.

This you say is the case for the request you saw the failure with, or
*all* barrier requests? In the latter case, what do you conclude this
from?

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] MULTI_mmu_update, HYPERVISOR_mmu_update and pte entry, Wei Liu

Next by Date:

[Xen-devel] [xen-unstable test] 7115: tolerable FAIL - PUSHED, xen . org

Previous by Thread:

Re: [Xen-devel] [GIT PULL] for-2.6.32/bug-fixes, Konrad Rzeszutek Wilk

Next by Thread:

Re: [Xen-devel] [GIT PULL] for-2.6.32/bug-fixes, Konrad Rzeszutek Wilk

Indexes:

[Date] [Thread] [Top] [All Lists]