This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: [PATCH] xen block backend driver.

On Wed, May 11, 2011 at 04:02:12PM +0100, Ian Campbell wrote:
> On Thu, 2011-05-05 at 19:11 +0100, Konrad Rzeszutek Wilk wrote:
> > This is the host side counterpart to the frontend driver
> > in drivers/block/xen-blkfront.c. The PV protocol is also implemented by
> > frontend drivers in other OSes too, such as the BSDs and even Windows.
> > 
> > The patch is based on the driver from the xen.git pvops kernel tree but
> > has been put through the checkpatch.pl wringer plus several manual
> > cleanup passes. It has also been moved from drivers/xen/blkback to
> > drivers/block/xen-blback.
> > 
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Reviewed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Not much to say below, mostly minor nits really.

Thanks for reviewing it. I believe I've taken all your apt comments
in consideration. Will post the v3.2 shortly.

> > +/*
> > + * Function to copy the from the ring buffer the 'struct blkif_request'
> Is the blkif namespace fair game? (I was asked to change netif is all)

It is shared with the frontend driver. I can definitly change it
but was thinking to do it once it is in the tree - that way it can
be one patch for both of them without having to worry about carrying
two branches for blkfront.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>