WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] libxl: virtio-blk-pci support for FV domain

To: Takeshi HASEGAWA <hasegaw@xxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] libxl: virtio-blk-pci support for FV domain
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Mon, 9 May 2011 10:04:28 +0100
Cc: Anthony Perard <anthony.perard@xxxxxxxxxx>, Xen Devel <Xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, Wei Liu <liuw@xxxxxxxxx>
Delivery-date: Mon, 09 May 2011 02:07:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <BANLkTi=eeu-wzDWCb-VithomzGk=EHjcVw@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <BANLkTin2+FtCL4-L1ZsZUov2153HiXSq7w@xxxxxxxxxxxxxx> <BANLkTimfyi1okskdUa=5CA0L=Ld-__QrGw@xxxxxxxxxxxxxx> <BANLkTinow-MbvrAmHf7uck=ybS95RCiFBQ@xxxxxxxxxxxxxx> <BANLkTi=eeu-wzDWCb-VithomzGk=EHjcVw@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sun, 2011-05-08 at 12:26 +0100, Takeshi HASEGAWA wrote:
> My patch threats virtio block devices with same manner with xvd, sd, and hd.
> Though, I need to discuss with xen developpers whether the vbd number
> assignment is reasonable or not.
> 
> I guess blktap and blkback will never handle virto block device, so assigning
> (reserving) the whole range of 2 << 28 for virtio block vbd may be more 
> better.

I think eating into that space would be better than exposing yet another
Linux specific major number in our interfaces.

> Actually virtio is not Xen's VBD, so vbd number is not mandatory to work.
> However, I believe this approach makes virtio block manageable
> in same way as xvd and others.
> 
> I am looking forward for xen developpers' opinions.
> 
> 
> Thanks,
> Takeshi
> 
> 2011/05/08 14:25 "Wei Liu" <liuw@xxxxxxxxx>:
> > On Sun, May 8, 2011 at 12:56 PM, Wei Liu <liuw@xxxxxxxxx> wrote:
> >> Thanks, I just started working on VirtIO block support yesterday.
> >>
> >> I was trying to add support to parse_disk_config() so that we can
> >> specify "-if" option in the config file.
> >>
> >> I'm wondering which approach is better -- configure through
> >> device_virtdisk_matches() or parse_disk_config() .
> >>
> >> Any suggestions?
> >
> > It seems that Takeshi's approach is better.
> >
> > I should follow libxl's conventions.
> >
> > --
> > Best regards
> > Wei Liu
> > Twitter: @iliuw
> > Site: http://liuw.name
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel