This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] libxl: virtio-blk-pci support for FV domain

To: Takeshi HASEGAWA <hasegaw@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] libxl: virtio-blk-pci support for FV domain
From: Wei Liu <liuw@xxxxxxxxx>
Date: Sun, 8 May 2011 13:24:53 +0800
Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen Devel <Xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Sat, 07 May 2011 22:26:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <BANLkTimfyi1okskdUa=5CA0L=Ld-__QrGw@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BANLkTin2+FtCL4-L1ZsZUov2153HiXSq7w@xxxxxxxxxxxxxx> <BANLkTimfyi1okskdUa=5CA0L=Ld-__QrGw@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Sun, May 8, 2011 at 12:56 PM, Wei Liu <liuw@xxxxxxxxx> wrote:
> Thanks, I just started working on VirtIO block support yesterday.
> I was trying to add support to parse_disk_config() so that we can
> specify "-if" option in the config file.
> I'm wondering which approach is better -- configure through
> device_virtdisk_matches() or parse_disk_config() .
> Any suggestions?

It seems that Takeshi's approach is better.

I should follow libxl's conventions.

Best regards
Wei Liu
Twitter: @iliuw
Site: http://liuw.name

Xen-devel mailing list