WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [PV Xen] Mouse stuck after save/restore of guest

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [PV Xen] Mouse stuck after save/restore of guest.
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Fri, 15 Apr 2011 11:37:38 +0200
Cc: dtor@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Igor Mammedov <imammedo@xxxxxxxxxx>
Delivery-date: Fri, 15 Apr 2011 02:40:10 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1302860272; l=1349; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=RDg1DvpmsiUOhsnpJupkVOAoMcU=; b=tkfiL6A9+76vyVK0Pril7lAWVCK8tIi+ttcBRGryHQUMf0cFVTvq8cQ+azKRTPxJzW4 JZ/DqcGHBZVlBalgpWH7yBtdp44N7+wNUtQAWiXosR7e0PjbqMubko9q0X5aHkwjnjOua ycevI7foDZGNQNjIzpqsuPn0c4+e9CteHtM=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110414183804.GB1467@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1302795907-321-1-git-send-email-imammedo@xxxxxxxxxx> <20110414155915.GA23629@xxxxxxxxxxxx> <20110414172649.GA7569@xxxxxxxxx> <20110414183804.GB1467@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Apr 14, Konrad Rzeszutek Wilk wrote:

> On Thu, Apr 14, 2011 at 07:26:50PM +0200, Olaf Hering wrote:
> > On Thu, Apr 14, Konrad Rzeszutek Wilk wrote:
> > 
> > > On Thu, Apr 14, 2011 at 05:45:07PM +0200, Igor Mammedov wrote:
> > > >     Mouse stuck after restore of PV guest but buttons are
> > > >     in working condition.
> > > >     If driver has been configured for ABS coordinates at
> > > >     start it will get XENKBD_TYPE_POS events and then
> > > >     suddenly after restore it'll start getting
> > > >     XENKBD_TYPE_MOTION events, that will be dropped later
> > > >     and they won't get into user-space.
> > > > 
> > > >     Regression was introduced by hunk 5 and 6 of 5ea5254
> > > >     in upstream.
> > > > 
> > > >     Driver on restore should ask xen for request-abs-pointer
> > > >     again if it's available. So restore parts that did it 
> > > >     before 5ea5254.
> > > 
> > > Olaf?
> > 
> > This change is correct. Thanks for spotting, Igor.
> 
> Dmitry,
> 
> Was wondering if you are OK pushing this for 2.6.39-rc3 or whether you are OK
> with me doing. It fixes a regression introduced by the last hunk of 
> 5ea5254aa0ad269cfbd2875c973ef25ab5b5e9db

Looking through my backlog, I noticed that the patch went also to
stable@xxxxxxxxxx and is now in various trees already.
So please forward this revert also to stable@xxxxxxx

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel