WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH]tools/libxl: fix a bug in libxl__build_device_mod

To: Christoph Egger <Christoph.Egger@xxxxxxx>, ian.campbell@xxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH]tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL
From: ZhouPeng <zpengxen@xxxxxxxxx>
Date: Fri, 15 Apr 2011 17:36:57 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 15 Apr 2011 02:38:57 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=9GILMwc+3Te6wgYOvSxYVd4Cs6+0eRvJ00fpW9IFVbY=; b=a738+iW34CsPTiTxvwyuQktcOqDnTIF+TmJwAfBkQoDtli5bmPXLbBT+ShZOMIMJnI Rvi5bTqrZfbh+Oi7138WqTEvdftuaDIEuPS9n3vmOotcJbjQm+Dnzes4IQqUuZWoXJr8 jVEbYYDNFgK8AfLjPnQgSv0yhZSrxG+HAk0UI=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=IHPkpnxYdAWTxKGDl1tHEYvNhSucQ7v7msszDoOrLwXUe1aEfjOvTSfj4nuQgNNfbB tSI6HrteZROxJuaNM2acWp/19V4OAlfVQok8B46cqmNCaYJngpL00IJk26ta/ARQhVII gwgmTQ3pX7HQvePXcNQrQ1xNqdIfw7CS+z6f8=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DA801C4.5060102@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BANLkTikOiFNm5OM+JFtpW6_32zTtpcUQYA@xxxxxxxxxxxxxx> <4DA801C4.5060102@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx


2011/4/15 Christoph Egger <Christoph.Egger@xxxxxxx>
On 04/15/11 10:33, ZhouPeng wrote:
Signed-off-by: Zhou Peng<zhoupeng@xxxxxxxxxxxxxxx>

tools/libxl: fix a bug in libxl__build_device_model_args_new. info->vncpasswd can't be empty if info->vncpasswd != NULL


NACK!  This can info->vncpasswd[0] contains '\0' if you have


  vncpasswd=''

in the guest config file.

 " if (info->vncpasswd&&  info->vncpasswd[0]) “ can
  vncpasswd='' in guest cfg file, when using upstream-qemu-xen
  and block vncpasswd='passwd'
  Can it be reasonable?

Christoph


diff -r 3f00c5faa12a tools/libxl/libxl_dm.c
--- a/tools/libxl/libxl_dm.c    Wed Apr 13 16:10:26 2011 +0100
+++ b/tools/libxl/libxl_dm.c    Fri Apr 15 09:45:43 2011 +0800
@@ -209,7 +209,7 @@ static char ** libxl__build_device_model
         int display = 0;
         const char *listen = "127.0.0.1";

-        if (info->vncpasswd&&  info->vncpasswd[0]) {
+        if (info->vncpasswd&&  !info->vncpasswd[0]) {
             assert(!"missing code for supplying vnc password to qemu");
         }
         flexarray_append(dm_args, "-vnc");

--
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)
<mailto:ailvpeng25@xxxxxxxxx>



--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel



--
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel