WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 4 of 5] tools: ocaml: add NIC QoS parameters to t

To: Dave Scott <Dave.Scott@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 4 of 5] tools: ocaml: add NIC QoS parameters to the ocaml libxl interface
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 29 Mar 2011 09:49:24 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 29 Mar 2011 01:50:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <455cc73ea6268d54bc94.1301315198@ely>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1301315194@ely> <455cc73ea6268d54bc94.1301315198@ely>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2011-03-28 at 13:26 +0100, Dave Scott wrote:
> # HG changeset patch
> # User David Scott <dave.scott@xxxxxxxxxxxxx>
> # Date 1301314652 -3600
> # Node ID 455cc73ea6268d54bc94e4c39ee954cef107f88b
> # Parent  3aab79c907a2c78f4e81362944ee65ddf6f2cc6f
> tools: ocaml: add NIC QoS parameters to the ocaml libxl interface
> 
> Signed-off-by: David Scott <dave.scott@xxxxxxxxxxxxx>

Looks good, modulo the impact of comments on previous patches:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> 
> diff -r 3aab79c907a2 -r 455cc73ea626 tools/ocaml/libs/xl/xl.ml
> --- a/tools/ocaml/libs/xl/xl.ml       Mon Mar 28 13:17:32 2011 +0100
> +++ b/tools/ocaml/libs/xl/xl.ml       Mon Mar 28 13:17:32 2011 +0100
> @@ -109,6 +109,8 @@
>               ifname : string;
>               script : string;
>               nictype : nic_type;
> +             qos_kib_per_sec : int32;
> +             qos_timeslice_usec : int32;
>       }
>  end
>  
> diff -r 3aab79c907a2 -r 455cc73ea626 tools/ocaml/libs/xl/xl.mli
> --- a/tools/ocaml/libs/xl/xl.mli      Mon Mar 28 13:17:32 2011 +0100
> +++ b/tools/ocaml/libs/xl/xl.mli      Mon Mar 28 13:17:32 2011 +0100
> @@ -109,6 +109,8 @@
>               ifname : string;
>               script : string;
>               nictype : nic_type;
> +             qos_kib_per_sec : int32;
> +             qos_timeslice_usec : int32;
>       }
>  end
>  
> diff -r 3aab79c907a2 -r 455cc73ea626 tools/ocaml/libs/xl/xl_stubs.c
> --- a/tools/ocaml/libs/xl/xl_stubs.c  Mon Mar 28 13:17:32 2011 +0100
> +++ b/tools/ocaml/libs/xl/xl_stubs.c  Mon Mar 28 13:17:32 2011 +0100
> @@ -225,7 +225,8 @@
>       c_val->ifname = dup_String_val(gc, Field(v, 6));
>       c_val->script = dup_String_val(gc, Field(v, 7));
>       c_val->nictype = (Int_val(Field(v, 8))) + NICTYPE_IOEMU;
> -
> +     c_val->qos_kib_per_sec = (Int_val(Field(v, 9)));
> +     c_val->qos_timeslice_usec = (Int_val(Field(v, 10)));
>  out:
>       CAMLreturn(ret);
>  }
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>