WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest ou

On Wed, 2011-03-23 at 16:57 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 25 of 30] libxl: move 
> libxl_doimid_valid_guest out of line"):
> > Why should it be inline?
> 
> In general, I think it's fine to have trivial operations like this
> inlined.  Things which one would otherwise maybe use a macro for.
> 
> > What actually led to the changes was that a subsequent patch removed the
> > indirect dependency which defined DOMID_FIRST_RESERVED. Rather than
> > finding and adding the appropriate xen header to libxl.h (which is a
> > valid option) I decided that the function shouldn't have been inline in
> > the first place...
> 
> I think it's fine to import Xen headers into libxl.h.

In any case whatever it was which caused me to do this is not present in
the final series I ended up sending and neither this patch nor any
additional #includes are required AFAICT.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>