WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest ou

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 25 of 30] libxl: move libxl_doimid_valid_guest out of line
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Wed, 23 Mar 2011 15:59:22 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 23 Mar 2011 09:11:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19850.5922.324253.63331@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1300723178@xxxxxxxxxxxxxxxxxxxxx> <825082d71dd594e0eee4.1300723203@xxxxxxxxxxxxxxxxxxxxx> <19850.5922.324253.63331@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2011-03-23 at 15:52 +0000, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH 25 of 30] libxl: move libxl_doimid_valid_guest 
> out of line"):
> > libxl: move libxl_doimid_valid_guest out of line
> 
> Why ?

Why should it be inline?

What actually led to the changes was that a subsequent patch removed the
indirect dependency which defined DOMID_FIRST_RESERVED. Rather than
finding and adding the appropriate xen header to libxl.h (which is a
valid option) I decided that the function shouldn't have been inline in
the first place...

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel