This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: xentrace: broken by c/s 23050:4ebba54b666f

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: [Xen-devel] Re: xentrace: broken by c/s 23050:4ebba54b666f
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Mon, 21 Mar 2011 22:23:20 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 21 Mar 2011 14:25:00 -0700
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1300742602; l=1169; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=SRvU86yRRLr8WYAzAQB+2h4ldVY=; b=OyoC+fdiak38w2R6iK41xcLetAgZnwqro8Uw/BOMf5i0wpmPxlIW10OBGXiDvSoFCcc REBBxk3F7F4Iyc2nZt1YMXqjzHZC1jePJthmgyJUSk3qkJ9t9uegwYCv6M7uragRuO/X0 O4zsGstqSh6WEvpyzUXWtiwizdsyFN2gJ6U=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110321173859.GA21766@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D87841B.1000102@xxxxxxx> <20110321173859.GA21766@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Mar 21, Olaf Hering wrote:

> On Mon, Mar 21, Christoph Egger wrote:
> > 
> > Hi,
> > 
> > C/s 23050:4ebba54b666f broke xentrace:
> > 
> > # xentrace -e 0x8f000 ./xentrace.out
> > (XEN) Xen trace buffers: cpu 0 p 0000000000000000
> The system you test on has 8 cpus, like mine.
> t_info_pages got too big, so alloc_xenheap_pages() failed.
> Can you add a printk to se whats happening in calculate_tbuf_size()?

compile tested patch:

# HG changeset patch
# Parent c81f0ef5a77d90fbf108d3efe489d08df45b63c2
xentrace: print calculated numbers in calculate_tbuf_size()

Print number of pages to allocate for per-cpu tracebuffer and metadata
to ease debugging when allocation fails.

Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>

diff -r c81f0ef5a77d xen/common/trace.c
--- a/xen/common/trace.c        Mon Mar 21 14:52:27 2011 +0000
+++ b/xen/common/trace.c        Mon Mar 21 21:49:52 2011 +0100
@@ -127,6 +127,8 @@
     t_info_pages /= PAGE_SIZE;
     if ( t_info_pages % PAGE_SIZE )
+    gdprintk(XENLOG_INFO, "requested %u t_info_pages for %u trace pages on %u 
+               t_info_pages, pages, num_online_cpus());
     return pages;

Xen-devel mailing list