This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: 2.6.39 merge window (git pulls and what is planned t

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: 2.6.39 merge window (git pulls and what is planned to go in)
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Tue, 15 Mar 2011 18:16:10 -0400
Cc: "rshriram@xxxxxxxxx" <rshriram@xxxxxxxxx>, Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Tue, 15 Mar 2011 15:17:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1300222727.15812.13.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20110310192946.GA9175@xxxxxxxxxxxx> <1299834691.17339.1797.camel@xxxxxxxxxxxxxxxxxxxxxx> <20110311142109.GA4880@xxxxxxxxxxxx> <1300201934.17339.2255.camel@xxxxxxxxxxxxxxxxxxxxxx> <AANLkTi=sEJexxiapPbkW7j4a08xkyx=iwRVdbxgGpZkQ@xxxxxxxxxxxxxx> <1300218769.15812.8.camel@xxxxxxxxxxxxxxxxxxxxx> <AANLkTi=e+M5jcdjVMmLXnuOPB9aS2rTjt66jo_Yba8SJ@xxxxxxxxxxxxxx> <1300222727.15812.13.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
> > > 4/5 needs to be upstream (via Rafael) first though, doesn't it? That's

> > > the keystone here, the rest appears to fall out nicely once that has
> > > gone in.
> > >
> > err, that was not the plan (though what you suggested would also work).
> > Look at thread
> > "Q: Clarification about extra option.."
> > http://lists.xensource.com/archives/html/xen-devel/2011-03/msg00267.html
> > 
> > The plan was that I would create a new tree by merging Rafael and
> > Stefano's trees. And then rebase my patches on this new tree, send out to
> > the list for review. Konrad meanwhile would pull this new tree+patches into 
> > his

So whatever I was hitting earlier on is gone (it also helps when I updated
my tools)

I took your tree, stuck it on top of my #linux-next and Stefano's #linux-next
and ran it with 'xm' (4.0) and 'xl' (4.1).

The 'xm save -c' and/or 'xm save' worked just great. The ping kept on going 
doing these 'xm save -c'. 

The 'xl save -c' on the other hand, failed on me. I don't know what the failure 
but I see this state in the guest: 

test                                         8  1024     4     ---ss-       5.3

I should update my xen-uinstable tree just to make sure I am not missing 

> > tree and push it after Rafael & Stefano's trees have gone in.
> If Rafael is happy with that plan then fine, but I didn't see him ack it
> in that thread (AFAICT he only acked the concept of what the patch would
> do). Either way someone still needs to follow up with him to get an Ack
> on the 4/5 patch since it is to the PM core, if he's subsequently also

Yup. Please do ping him for his ACK. He needs to OK


patch. Which btw, I looked in a kernel built before your patch
and had /sys/power/state contain "mem disk" (good). With your patch
and with 

the /sys/power/state contained only "mem". Which is expected and
what the patch is suppose to do.

But what surprising is that I still had the /sys/power/disk attribute?

Also I saw this during compile:

/home/konrad/ssd/linux/kernel/power/hibernate.c:556: warning: ‘power_down’ 
defined but not used
/home/konrad/ssd/linux/kernel/power/user.c:68: warning: ‘snapshot_open’ defined 
but not used
/home/konrad/ssd/linux/kernel/power/user.c:128: warning: ‘snapshot_release’ 
defined but not used
/home/konrad/ssd/linux/kernel/power/user.c:149: warning: ‘snapshot_read’ 
defined but not used
/home/konrad/ssd/linux/kernel/power/user.c:182: warning: ‘snapshot_write’ 
defined but not used
/home/konrad/ssd/linux/kernel/power/user.c:220: warning: ‘snapshot_ioctl’ 
defined but not used

Which you should address (you could send a follow-up patch for it).
Hadn't tried to compile this under i386 so no idea if there are any
warnings there either.

> ok with taking it through a tree other than his own then great.

I stuck it in #linux-next-kitchensink

Will re-organize it appropiately soon.
> Ian.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>