This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 13/14] xen: events: do not workaround too-small n

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 13/14] xen: events: do not workaround too-small nr_irqs
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Thu, 10 Mar 2011 09:02:56 +0000
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 10 Mar 2011 01:04:41 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20110310054045.GF10574@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1299692459.17339.700.camel@xxxxxxxxxxxxxxxxxxxxxx> <1299692486-28634-13-git-send-email-ian.campbell@xxxxxxxxxx> <20110310054045.GF10574@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2011-03-10 at 05:40 +0000, Konrad Rzeszutek Wilk wrote:
> On Wed, Mar 09, 2011 at 05:41:25PM +0000, Ian Campbell wrote:
> > This workaround was somewhat useful prior to the introduction of the
> > core irq allocator and 026c9d2d0d75 "xen: events: allocate GSIs and
> > dynamic IRQs from separate IRQ ranges." but should be unnecessary now.
> OK, so you tested this under QEMU with Xen + Dom0? A simple one CPU
> config was what we had trouble with.

Yes, I tested with:
qemu-system-x86_64 -m 256 -vnc -k en-gb -serial stdio -boot nc \
        -usb -usbdevice tablet \
        -net nic,vlan=0,macaddr=00:16:3e:3f:73:b6,model=e1000 \
        -net tap,vlan=0,ifname=tapQEMU.0 \
        -hda /dev/VG/debian-HVM-1

Booting a recent Xen hypervisor + this kernel.

The comment should really have been updated to reflect the importance of
e7bcecb7b1d2 rather than 026c9d2d0d75. I'll update to:

        With the introduction of e7bcecb7b1d2 "genirq: Make nr_irqs
        runtime expandable" nr_irqs can grow as necessary to accommodate
        our allocation requests.


> > 
> > If nr_irqs turns out to be too small under Xen then we should increase
> > nr_irqs rather than working around the core allocator in this way.
> > 
> > In my configuration NR_IRQS ends up being 2304 with nr_irq_gsi 272
> > which is sufficient.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>