WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] Re: [PATCH] Fix cpu offline bug

To: Jan Beulich <JBeulich@xxxxxxxxxx>, Keir Fraser <keir.xen@xxxxxxxxx>
Subject: RE: [Xen-devel] Re: [PATCH] Fix cpu offline bug
From: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>
Date: Tue, 8 Mar 2011 17:47:32 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Li, Xin" <xin.li@xxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Delivery-date: Tue, 08 Mar 2011 01:49:22 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D75FC5702000078000351B2@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BC00F5384FCFC9499AF06F92E8B78A9E1FA4F5A806@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C9967421.14234%keir.xen@xxxxxxxxx> <4D75FC5702000078000351B2@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcvdbnntbVow+AFoRG24ua2xh2k4SgABtfOA
Thread-topic: [Xen-devel] Re: [PATCH] Fix cpu offline bug
Jan, I'm not quite clear your meaning.
Why and where need to insert barrier, or volatile cpu_state?

Thanks,
Jinsong

Jan Beulich wrote:
>>>> On 05.03.11, Keir Fraser <keir.xen@xxxxxxxxx> wrote: Urk, good
>>>> point! 
> 
> But your fix still allows what the comment says it is supposed to
> avoid - simply introducing a variable doesn't help afaict, you also
> need to insert a barrier() to avoid a second read (or "cpu_state"
> would need to be volatile).
> 
> Jan
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel