WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

[Xen-devel] Re: [PATCH] Fix cpu offline bug

from [Jan Beulich] [Permanent Link][Original]
To: "Keir Fraser" <keir.xen@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] Fix cpu offline bug
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 08 Mar 2011 08:52:23 +0000
Cc: Jinsong Liu <jinsong.liu@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Yunhong Jiang <yunhong.jiang@xxxxxxxxx>, Xin Li <xin.li@xxxxxxxxx>
Delivery-date: Tue, 08 Mar 2011 00:55:06 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C9967421.14234%keir.xen@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <BC00F5384FCFC9499AF06F92E8B78A9E1FA4F5A806@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C9967421.14234%keir.xen@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
>>> On 05.03.11, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
>Urk, good point!

But your fix still allows what the comment says it is supposed to avoid
- simply introducing a variable doesn't help afaict, you also need to
insert a barrier() to avoid a second read (or "cpu_state" would need
to be volatile).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  [Xen-devel] [xen-4.1-testing test] 6335: regressions - FAIL, xen . org
Next by Date:  Re: [Xen-devel] [PATCH 2 of 8] x86: add explicit size suffixes to some assembly instructions, Jan Beulich
Previous by Thread:  [Xen-devel] Re: [PATCH] Fix cpu offline bug, Keir Fraser
Next by Thread:  RE: [Xen-devel] Re: [PATCH] Fix cpu offline bug, Liu, Jinsong
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy