[Xen-devel] Re: [PATCH] Make explicit message when guest failed

To:	Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject:	[Xen-devel] Re: [PATCH] Make explicit message when guest failed to suspend
From:	Frank Pan <frankpzh@xxxxxxxxx>
Date:	Thu, 3 Mar 2011 19:22:58 +0800
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date:	Thu, 03 Mar 2011 03:40:26 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=0FRf6z8+eBVcULWRLmA5oKFsZRlThgQMPNzBLivymuM=; b=I+deJKnoX+owuRzArY14msyMXid0ccmyB6n1p/ImgnHg/4vg//QTJXYOwVXbnHS9LK bEUoMEivuJuSIQvwUqdqTtbEradAjSghMt69qI3fblFNSHUazNmBTgXOTNPsFwY3+SEp 0xfKugarWvGq7/K4NFHYdk9LbdS+a2M10y3Bs=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=wtBjUKe2H+Y9apKs44ABFJjDXfEPXFJTKu60fCI7BMpGCaBWjeibTs7CmhBE0//7ly E8/UZ2L1lFTztC1Vv0av8jtnKjfEP/am4xDnzR3483nDRBGrMkqu3ASK6XTbVrnZfGpr I6fdnkH7+ds9bSJ46gxBnWjUe3FvTmGlPyZrw=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<1299149781.17907.1840.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<AANLkTi=Jg2eWzCMR6Zksdpf=5sDUeu8L1Q7WE354dR-h@xxxxxxxxxxxxxx> <1299149781.17907.1840.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

> This is a bug in Xend, it should never enter an infinite loop regardless
> of guest behaviour. The code certainly appears to expect to be managing
> a timeout, perhaps it has bitrotted?
>
> I don't think you can change the xenbus protocol in this way without
> further rationale regarding it's correctness.
>
> Perhaps a separate control/shutdown-error key? The message written
> should be more verbose than just "failed" if/when more specific
> information is available to the kernel.

FP: Maybe I should seperate it into 2 patches? One for bug fixing, the
other for new protocol?

> In particular you need to consider and explain how it remains compatible
> with a new kernel running on older toolstacks and vice versa.
>

FP: Right. This is something I haven't considered yet.

-- 
Frank Pan

Computer Science and Technology
Tsinghua University

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: [PATCH] Make explicit message when guest failed to suspe