WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2/3] xen: use freeze/restore/thaw PM events for s

To: Shriram Rajagopalan <rshriram@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/3] xen: use freeze/restore/thaw PM events for suspend/resume/chkpt
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Tue, 22 Feb 2011 17:36:38 -0500
Cc: "Rafael J. Wysocki" <rjw@xxxxxxx>, linux-pm@xxxxxxxxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, Iam Campbell <ian.campbell@xxxxxxxxxx>, Pavel Machek <pavel@xxxxxx>
Delivery-date: Tue, 22 Feb 2011 14:38:11 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTikrUUG92vQS_ZkdKCZ_+1BahQfAhRB-=8eNNW2o@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1298157158-5421-1-git-send-email-rshriram@xxxxxxxxx> <1298157158-5421-3-git-send-email-rshriram@xxxxxxxxx> <20110222204320.GB4605@xxxxxxxxxxxx> <AANLkTikrUUG92vQS_ZkdKCZ_+1BahQfAhRB-=8eNNW2o@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
> > Could we just make CONFIG_XEN_SAVE_RESTORE depend on CONFIG_HIBERANTION?
> > Like this:
> >
> >
> > diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> > index 5b54892..838e20c 100644
> > --- a/arch/x86/xen/Kconfig
> > +++ b/arch/x86/xen/Kconfig
> > @@ -38,7 +38,7 @@ config XEN_MAX_DOMAIN_MEMORY
> >
> >  config XEN_SAVE_RESTORE
> >        bool
> > -       depends on XEN && PM
> > +       depends on XEN && PM && HIBERNATION
> >        default y
> >
> >  config XEN_DEBUG_FS
> >
> >
> On that aspect, just noticed
> config PM_SLEEP
>         bool
>         depends on SUSPEND || HIBERNATION || XEN_SAVE_RESTORE
>         default y
> we could get rid of XEN_SAVE_RESTORE as the suspend/resume code doesnt
> depend on PM_SLEEP

OK. Do you want to respin patch #2 without the #ifdefs in the drivers/base/...
and provide a new patch (#4?) which will alter the Kconfig file appropriately?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>