|
xen-devel
[Xen-devel] Re: [PATCH] fix pgd_lock deadlock
|
To: |
Johannes Weiner <jweiner@xxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [PATCH] fix pgd_lock deadlock |
|
From: |
Andrea Arcangeli <aarcange@xxxxxxxxxx> |
|
Date: |
Mon, 21 Feb 2011 15:30:23 +0100 |
|
Cc: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, Hugh Dickins <hughd@xxxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Andi Kleen <andi@xxxxxxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Larry Woodman <lwoodman@xxxxxxxxxx> |
|
Delivery-date: |
Mon, 21 Feb 2011 06:32:02 -0800 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20110217101941.GH2380@xxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<4D4B1392.5090603@xxxxxxxx> <20110204012109.GP5843@xxxxxxxxxxxxx> <4D4C6F45.6010204@xxxxxxxx> <20110207232045.GJ3347@xxxxxxxxxxxxx> <20110215190710.GL5935@xxxxxxxxxxxxx> <alpine.LFD.2.00.1102152020590.26192@xxxxxxxxxxxxxxxxxxxxxxx> <20110215195450.GO5935@xxxxxxxxxxxxx> <alpine.LFD.2.00.1102152102530.26192@xxxxxxxxxxxxxxxxxxxxxxx> <20110216183304.GD5935@xxxxxxxxxxxxx> <20110217101941.GH2380@xxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Thu, Feb 17, 2011 at 11:19:41AM +0100, Johannes Weiner wrote:
> So Xen needs all page tables protected when pinning/unpinning and
> extended page_table_lock to cover kernel range, which it does nowhere
> else AFAICS. But the places it extended are also taking the pgd_lock,
> so I wonder if Xen could just take the pgd_lock itself in these paths
> and we could revert page_table_lock back to cover user va only?
> Jeremy, could this work? Untested.
If this works for Xen, I definitely prefer this.
Still there's no point to insist on _irqsave if nothing takes the
pgd_lock from irq, so my patch probably should be applied anyway or
it's confusing and there's even a comment saying pgd_dtor is called
from irq, if it's not it should be corrected. But then it becomes a
cleanup notafix.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, (continued)
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, Andrea Arcangeli
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, Konrad Rzeszutek Wilk
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, Johannes Weiner
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock,
Andrea Arcangeli <=
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, Johannes Weiner
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, Jan Beulich
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, Andrea Arcangeli
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, Jan Beulich
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, Andrea Arcangeli
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, Jeremy Fitzhardinge
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, Andrea Arcangeli
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, Andrea Arcangeli
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, Jan Beulich
- [Xen-devel] Re: [PATCH] fix pgd_lock deadlock, Andrea Arcangeli
|
|
|
Home