WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH]do not allow multiple xenconsole connect to the s

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH]do not allow multiple xenconsole connect to the same pty
From: Li Dongyang <lidongyang@xxxxxxxxxx>
Date: Thu, 17 Feb 2011 11:32:43 +0800
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Wed, 16 Feb 2011 19:33:36 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19802.54932.293842.532179@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201102151207.38331.lidongyang@xxxxxxxxxx> <19802.54932.293842.532179@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.13.6 (Linux/2.6.38-rc4-btrfs+; KDE/4.6.0; x86_64; ; )
On Wednesday, February 16, 2011 03:40:04 AM Ian Jackson wrote:
> Li Dongyang writes ("[Xen-devel] [PATCH]do not allow multiple xenconsole 
> connect to the same pty"):
> > allowing multiple xenconsole connect to the same pty is just insane,
> > prevent this by acquiring a write flock on the pty fd once we opened it.
> 
> I don't think that flocking a pty is likely to be very portable.
Thanks for reviewing, and what do you mean by 'not likely to be very portable'?
flock(2) is not POSIX, but fcntl(3p) is POSIX, maybe I missed somthing?

Li Dongyang
> 
> I guess what happens at the moment if you do this is that input is
> interleaved (fine) but output is distributed randomly amongst the
> available clients ?
> 
> Ian.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel