 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [xen-devel][RFC] xl disk configuration handling
| To: | Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [xen-devel][RFC] xl disk configuration handling |
| From: | Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx> |
| Date: | Tue, 01 Feb 2011 09:00:35 -0500 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Tue, 01 Feb 2011 06:02:05 -0800 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=QCvVuCU1q0Q7FygEjArB1+Fv/aGpex9IdN03946btjc=; b=iHsVz8izW0b3Jr/YeuGgGbek8eK8LzCUL/hdpHw2YkekCuDMb4V0OmW8ICPfj6Bfgh WM6WbPhw+CnInR0ZvaDM2VtTTPFWpD9zQQOOK8T+xfWaCbMyItX1CmFxp/fqdcB5xWbt 6WAlU4owGDwOa2vg2Thzr4gxA+SphbaMk8URw= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=ulZlB+MtzqtxcbL8opJlHadxteTjO8j61VRf62KSxMm/rtmGSbaAMIvhugmwvFt6R7 rKBlNFLq2qkembQyIPrr2FjcVeqSsNwCvkAMkgMKjCWWgc47w7kzknEl1Hk3eSkjOXSp lvAx+yvKSHerp8hBAJwVl0XXjQJWg+GNgZ8eE= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <alpine.DEB.2.00.1102011102180.7277@kaball-desktop> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <4D45A410.4000304@xxxxxxxxx> <alpine.DEB.2.00.1101311644090.7277@kaball-desktop> <4D471955.8070103@xxxxxxxxx> <alpine.DEB.2.00.1102011102180.7277@kaball-desktop> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Thunderbird 2.0.0.24 (X11/20101027) |
>>> do we really need to change the parsing function that much? I >>> understand there are significant changes but this is a total rewrite. >>> I am concerned about all the bugs we might find later after the >>> release... >>> >> This is one change I would really like to go with. Not only does it help >> with >> the changes we needed, it also gets rid of code duplication. With this >> change >> block-attach can rely on the same parsing code (that is once I submit the >> block-attach changes patch). > > It took us several iterations to get the parsing right, I would like to > keep the state machine and the field parsing as it is, but each case > could have its own function to implement it. In other words, would you > be OK with calling parse_disk_attrib, parse_disk_vdev_info and > parse_disk_pdev_info from the main switch under DSTATE_PHYSPATH, > DSTATE_VIRTPATH, etc? Sure, I will go with appropriate DSTATE_* for each chunk we parse. Kamala _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] DSN: failed (gibbsint@xxxxxxxxxxxxxxx), Mailbot for etexusa . com |
|---|---|
| Next by Date: | Re: [Xen-devel] [memory sharing] bug on get_page_and_type, Tim Deegan |
| Previous by Thread: | Re: [xen-devel][RFC] xl disk configuration handling, Stefano Stabellini |
| Next by Thread: | Re: [Xen-devel] PCI passthrough issue, Ian Campbell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
