This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] vscsi 2TB patches

>>> On 04.01.11 at 14:23, Samuel Kvasnica <bugreports@xxxxxxxxxxxxxx> wrote:
> On 01/04/2011 02:07 PM, Jan Beulich wrote:
>> I wasn't actually after the printk(), but rather noticing your original
>> scsifront patch apparently consisted of only an added comment;
>> that I was wrong with actually (not being used to read non-unified
>> diffs), but your newer patch still contains a number of apparently
>> arbitrary newline insertions and removals.
> is this ok now ?

I was about to ack this (given the lack of a response from the
original authors, and after looking over it again), when I noticed
an apparent inconsistency: {READ,WRITE}_{6,10,16} are all
un-commented now in scsiback_emulation_init(), but
{READ,WRITE}_12 remain commented. Why is that?

Thanks, Jan

Xen-devel mailing list