This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] libxl_cdrom_insert

On Sat, 15 Jan 2011, Ian Campbell wrote:
> On Fri, 2011-01-14 at 22:37 +0000, Kamala Narasimhan wrote: 
> > Do we know the rationale behind setting disk->physpath to "" in the
> > below code in libxl?  Hopefully there is more to it than to avoid a
> > potential null pointer crash at a later point :)
> I think it might indicate an empty CDROM drive in the HVM case. Arguably
> a PHYSTYPE_EMPTY/NONE or some such concept might have been clearer. "hg
> annotate" should lead you to the original commit.

Yes, that is what it means: libxl callers set physpath to NULL to eject
a cdrom, however libxl_device_disk_add cannot handle NULL physpath's.
I think we should introduce PHYSTYPE_EMPTY and start using it in
libxl.c:libxl_event_get_disk_eject_info and xl_cmdimpl.c:cd_insert.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>