This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] libxl_cdrom_insert

To: Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>
Subject: Re: [Xen-devel] libxl_cdrom_insert
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Sat, 15 Jan 2011 15:03:48 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sat, 15 Jan 2011 07:04:41 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTim2J=oxtoDcEJTeq69v6c0Z=wrYB_PzcbwP=zMP@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <AANLkTim2J=oxtoDcEJTeq69v6c0Z=wrYB_PzcbwP=zMP@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2011-01-14 at 22:37 +0000, Kamala Narasimhan wrote: 
> Do we know the rationale behind setting disk->physpath to "" in the
> below code in libxl?  Hopefully there is more to it than to avoid a
> potential null pointer crash at a later point :)

I think it might indicate an empty CDROM drive in the HVM case. Arguably
a PHYSTYPE_EMPTY/NONE or some such concept might have been clearer. "hg
annotate" should lead you to the original commit.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>