This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Last call for forgotten tools patches for Xen 4.1

To: Chun Yan Liu <CYLiu@xxxxxxxxxx>
Subject: Re: [Xen-devel] Last call for forgotten tools patches for Xen 4.1
From: Jim Fehlig <jfehlig@xxxxxxxxxx>
Date: Thu, 13 Jan 2011 08:48:54 -0700
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Thu, 13 Jan 2011 07:49:42 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19758.58723.681181.302589@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <19750.386.258317.29710@xxxxxxxxxxxxxxxxxxxxxxxx> <4D2E3417.1020208@xxxxxxxxxx> <19758.58723.681181.302589@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20081112)
Ian Jackson wrote:
> Jim Fehlig writes ("Re: [Xen-devel] Last call for forgotten tools patches for 
> Xen 4.1"):
>> Sorry for the delay, but I just noticed this tools patch submitted by
>> Chun Yan back in November
>> http://lists.xensource.com/archives/html/xen-devel/2010-11/msg01559.html
> Thanks.  I replied to that but there was no updated patch.

Opps, I thought Chunyan had sent an updated patch but perhaps have
confused this with her qemu keysym patches.

> Now that I look at the patch again I see some other problems:
>  * It closes the fd onto the file after locking it with flock (!)
>  * On success it unlinks the lock file after locking it (!!)
>  * The error return value is wrong (or perhaps it was wrong before).

Err, right.  And there was no follow-up as I assumed.  Chunyan, can you
address Ian's comments and submit an updated patch?


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>