This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Last call for forgotten tools patches for Xen 4.1

To: Jim Fehlig <jfehlig@xxxxxxxxxx>
Subject: Re: [Xen-devel] Last call for forgotten tools patches for Xen 4.1
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Thu, 13 Jan 2011 11:43:31 +0000
Cc: Chun Yan Liu <CYLiu@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 13 Jan 2011 03:45:11 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D2E3417.1020208@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <19750.386.258317.29710@xxxxxxxxxxxxxxxxxxxxxxxx> <4D2E3417.1020208@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Jim Fehlig writes ("Re: [Xen-devel] Last call for forgotten tools patches for 
Xen 4.1"):
> Sorry for the delay, but I just noticed this tools patch submitted by
> Chun Yan back in November
> http://lists.xensource.com/archives/html/xen-devel/2010-11/msg01559.html

Thanks.  I replied to that but there was no updated patch.

Now that I look at the patch again I see some other problems:
 * It closes the fd onto the file after locking it with flock (!)
 * On success it unlinks the lock file after locking it (!!)
 * The error return value is wrong (or perhaps it was wrong before).
It is evident that this patch cannot have been properly tested since
it won't actually provide mutual exclusion in its current form.

I think we should look at this again after the 4.1 release.


Xen-devel mailing list