This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xend: drbd improvements

To: Jim Fehlig <jfehlig@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xend: drbd improvements
From: Shriram Rajagopalan <rshriram@xxxxxxxxx>
Date: Wed, 12 Jan 2011 23:36:11 -0800
Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Berthold Gunreben <bg@xxxxxxx>
Delivery-date: Wed, 12 Jan 2011 23:38:08 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=f0ByXGXO7JsiYKvfLeAiUu3oxSa+WqLBhWYJlp7Y3wI=; b=ZXA6AOF/WwRPmVQxMZYe8R7k/mXL4oDxFwNH3i0JMNx4i8qhoygDndm3VI1rm1+STo UWaNf8+JjwSImBgdjhuMvhBlchtVJsO0c7Jbsvy/bJGxnJmYOv4z3aNiuRQ6Cp4IauXz gDUF3e4tGBa6WWMRjIWeNiP0eWaNXgi9tTPSY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=c0IdybONX4mxQ3H5TTaHapJeHyim3LvDXqpuelv70NC7VTTcUeGjREmgpcB57BiXpH /qxcnqOCm/rojhJvFTc1fd4solf/EEgRNAVxE3ddFPfr9jWU5Bj3E2MAflwSEHrVPLOJ E/rRNoVWuFARXD9zOKsGaV1FcRSP1i8kU731Y=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D2E73A4.6050203@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <fb0498c0cbdd6be20bbc.1289325040@xxxxxxxxxxxxxxxxxxxxxxxxx> <19673.37479.133902.499115@xxxxxxxxxxxxxxxxxxxxxxxx> <4CD9C962.4030701@xxxxxxxxxx> <4CDADB46.7020100@xxxxxxxxxx> <4D0AB298.4080202@xxxxxxxxxx> <19748.65417.734677.848857@xxxxxxxxxxxxxxxxxxxxxxxx> <AANLkTi=Q9SvP1DCgkTHbuB0XKc7Y_vT=V3syqdcEgizx@xxxxxxxxxxxxxx> <4D2B96C7.4050508@xxxxxxxxxx> <4D2E73A4.6050203@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
darn!.. I missed your earlier email totally, in the flood of emails in
my inbox :(. sorry about
the delayed response.

I dont have pygrub based vm disk images/volumes on my Debian devel boxes.
But I have tested your patches (revert 20158, 19444 & applying your
patch) with pv domUs,
using the "block-drbd" script and the following work fine as expected.
   --Promoting drbd resource to primary before booting VM
   --Automatic secondary->primary resource promotion (at target host)
during live migration


On Wed, Jan 12, 2011 at 7:38 PM, Jim Fehlig <jfehlig@xxxxxxxxxx> wrote:
> Jim Fehlig wrote:
>> Shriram Rajagopalan wrote:
>>> I was just looking over the patch on blkif.py and I believe there is a bug.
>>> --- a/tools/python/xen/util/blkif.py Fri Dec 10 18:08:19 2010 +0000
>>> +++ b/tools/python/xen/util/blkif.py Wed Jan 05 23:31:24 2011 +0000
>>> @@ -71,15 +71,8 @@ def _parse_uname(uname):
>>>      if uname.find(":") != -1:
>>>          (typ, fn) = uname.split(":", 1)
>>> -        if typ == "phy" and not fn.startswith("/"):
>>> +        if typ in ("phy", "drbd") and not fn.startswith("/"):
>>>              fn = "/dev/%s" %(fn,)
>>> -
>>> -        if typ == "drbd":
>>> -            if not fn.startswith("drbd"):
>>> -                (drbdadmstdin, drbdadmstdout) =
>>> os.popen2(["/sbin/drbdadm", "sh-dev", fn])
>>> -                fn = drbdadmstdout.readline().strip()
>>> -            else:
>>> -                fn = "/dev/%s" %(fn,)
>>>          if typ in ("tap", "tap2"):
>>>              (taptype, fn) = fn.split(":", 1
>>>  When you specify a drbd disk for a domU, its format is
>>>   drbd:<resourceName>
>> Correct.  Sadly, I forgot I was testing on SLES, which contains local
>> xend patches to fix problems wrt external block scripts.  One of the
>> patches has existed for ages, before many of us were working on xen
>> :-).  I would really like to get these changes upstream, even though
>> xend is dying.  The first patch is a revert of
>> http://xenbits.xensource.com/xen-unstable.hg?rev/152257350930.  The
>> second patch, which I've rebased against -unstable, is attached.  Can
>> you test it?
> Shriram,
> Have you had a chance to test my suggestion above (reverting c/s 19444
> and using the xend patch we have in SuSE)?  It has been working well for
> us, but another "Tested-by:" may convince upstream to take these changes
> as well.  Perhaps it is too late for 4.1 as we're at RC2 already.
> Thanks!
> Jim

perception is but an offspring of its own self

Xen-devel mailing list