This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xend: drbd improvements

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xend: drbd improvements
From: Shriram Rajagopalan <rshriram@xxxxxxxxx>
Date: Thu, 6 Jan 2011 09:48:02 -0800
Cc: Jim Fehlig <jfehlig@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Berthold Gunreben <bg@xxxxxxx>
Delivery-date: Thu, 06 Jan 2011 09:49:09 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=nW4TOjaoP3hRaaNHpTFy7O/sl7eTkZZ6VuM2UL5pulU=; b=rl7xasDZsdRKDq/+8CzBEf2Gpi0MP8w3UweePT0adXaPEw5ycDr17x0UVsq3S89UL0 qhLdW/2GpGzS1UIGUi7MUHJXsmcltVwLvlpzo9Q08bt50NEYXZ8UUcffWHosW7o56lLW xOWd6GYINoVvPEcemvvTL0pAsmhdKHjMGKg9A=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=u9eUdTQFDrY1rPg3D+m707Rqzn/tY8DH+QCcknadBlgBBAKLQvVz3kbpbhVXPvpzeO TbjXiVhBT0S242hWSes8DiYELy+/rYDc0YQZ3oN1wFg+Gaj31nNcikanRW2cX01Ukhy2 J9nSahRqoxfifuu4j21JRHVp1J2SmjyTTZHpc=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19748.65417.734677.848857@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <fb0498c0cbdd6be20bbc.1289325040@xxxxxxxxxxxxxxxxxxxxxxxxx> <19673.37479.133902.499115@xxxxxxxxxxxxxxxxxxxxxxxx> <4CD9C962.4030701@xxxxxxxxxx> <4CDADB46.7020100@xxxxxxxxxx> <4D0AB298.4080202@xxxxxxxxxx> <19748.65417.734677.848857@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
I was just looking over the patch on blkif.py and I believe there is a bug.
--- a/tools/python/xen/util/blkif.py    Fri Dec 10 18:08:19 2010 +0000
+++ b/tools/python/xen/util/blkif.py    Wed Jan 05 23:31:24 2011 +0000
@@ -71,15 +71,8 @@ def _parse_uname(uname):
     if uname.find(":") != -1:
         (typ, fn) = uname.split(":", 1)

-        if typ == "phy" and not fn.startswith("/"):
+        if typ in ("phy", "drbd") and not fn.startswith("/"):
             fn = "/dev/%s" %(fn,)
-        if typ == "drbd":
-            if not fn.startswith("drbd"):
-                (drbdadmstdin, drbdadmstdout) =
os.popen2(["/sbin/drbdadm", "sh-dev", fn])
-                fn = drbdadmstdout.readline().strip()
-            else:
-                fn = "/dev/%s" %(fn,)

         if typ in ("tap", "tap2"):
             (taptype, fn) = fn.split(":", 1

 When you specify a drbd disk for a domU, its format is
wherein drbd expects a resource file in /etc/drbd.d/resourceName.res, that
contains the actual drbd device name (/dev/drbd1 or something).
 drbd does not export resources as devices in the /dev/ path (as is
the assumption
in the above patch). It actually exports them under /dev/drbd/by-res/.
Atleast thats
the case in my Debian box, with drbd 8.3.9

I can send out a patch if you folks agree with this.


On Wed, Jan 5, 2011 at 3:32 PM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Jim Fehlig writes ("Re: [Xen-devel] [PATCH] xend: drbd improvements"):
> > Sorry for the delay here, but I finally got around to investigating this
> > further.  As it turns out, drbd's block-drbd script handles all of the
> > details that c/s 20158 introduces within xend :-(.  IMO, this c/s should
> > be reverted as it causes a regression.  I've tested drbd without this
> > changeset and it works fine.
> Thanks for looking into this and testing things.  I have reverted
> 20158 from xen-unstable.
> Ian.
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

perception is but an offspring of its own self

Xen-devel mailing list