Re: [Xen-devel] [PATCH][VTD] bug fix for EPT/VT-d table sharing

To:	Olaf Hering <olaf@xxxxxxxxx>, "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH][VTD] bug fix for EPT/VT-d table sharing
From:	Keir Fraser <keir@xxxxxxx>
Date:	Mon, 10 Jan 2011 10:32:31 +0000
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date:	Mon, 10 Jan 2011 02:38:57 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=XpAEI1eMPY3C2oyAwShmvRuurezom2eQqUoQpQgegdo=; b=uqQ0AFrg4zsyQ6ONOmFOpkBjHxXDqnGxYwVyMj0lwnLJb+2skOeGiIoylv2XmOSM1R idYikKL6jRij4n9A0bJm8QfqMz4EBXXNt54bOdh96Ipw+rW+PvOWoWKIRFhsK//9uvoB k/wcUcpbXp/b8sKpuOJH4ybc8D/ElY63bPYWo=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=xwuW0FZb193/hQ1BC+RIZsHGYh5cGaBb6FjqYRoubKuIiHgTEn/iiIPfof3i0/YTZE K5tKgKWymvwDqe7JGPLHfnZPivOOA/FKm+wFnG9juqYlSLfZLWgFezI/m/T7Jn3D+QyZ L2qmGGZME0i2dMqwyvorfmYYDCdgyNa3yEQzk=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<20110110095254.GA2472@xxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Acuwsa97gpLH9I2jOEqZOo4qta3TcA==
Thread-topic:	[Xen-devel] [PATCH][VTD] bug fix for EPT/VT-d table sharing
User-agent:	Microsoft-Entourage/12.27.0.100910

On 10/01/2011 09:52, "Olaf Hering" <olaf@xxxxxxxxx> wrote:

> On Fri, Jan 07, Kay, Allen M wrote:
> 
>>> @@ -548,17 +533,12 @@ static int inline iommu_flush_iotlb_psi(
>>>     if ( !cap_pgsel_inv(iommu->cap) )
>>>         return iommu_flush_iotlb_dsi(iommu, did, flush_non_present_entry,
>>> flush_dev_iotlb);
>>> 
>>> -    /*
>>> -     * PSI requires page size is 2 ^ x, and the base address is naturally
>>> -     * aligned to the size
>>> -     */
>>> -    align = get_alignment(addr >> PAGE_SHIFT_4K, pages);
>>>     /* Fallback to domain selective flush if size is too big */
>>> -    if ( align > cap_max_amask_val(iommu->cap) )
>>> +    if ( order > cap_max_amask_val(iommu->cap) )
> 
> This leaves 'align' uninitialized when flush->iotlb() is called.
> 
> iommu.c:546: error: 'align' may be used uninitialized in this function

I fixed this as of c/s 22696.

 -- Keir

> 
> Olaf
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH][VTD] bug fix for EPT/VT-d table sharing