This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 3 of 5] mem_access: public interface changes

To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3 of 5] mem_access: public interface changes
From: Joe Epstein <jepstein98@xxxxxxxxx>
Date: Tue, 4 Jan 2011 07:37:31 -0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 04 Jan 2011 07:39:13 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=zvMa6LyACqSn158ttfbLsw7VA/AS13C3EileB1h6lgc=; b=IlZHC92y8DVv/fLXON12xAnwNdUGVIsC55TnBWvVNdY3Zb7U2HEKjh+10Gfvc4RaST 39NPs6owiAhtru0Lv6J0ZW7cVvkD+rDOzGZZcLEobCSYA6FhKIPXXk9HM/RrQa9WGpX5 SyycHqFG0EnS5xdpRtBCO/6by9n5ZEuAokGhk=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=F/6fobMEh69MLFNW1w5MQ9qlYQgWaJyzyS3KOo7XUEvZs2Jj+sX7/526P59Ruq6nzr pQtqykqWUE2Cnc7qR4dGJh6z4WO6Z96CQuYeSk/CI4TYfj6MM7MhWQMv9ZZbWx8Y4GOb yvSTOeT96Dw9MNJyZVOsckaN3ybQBn3HRtfqE=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1294152308.3831.290.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTim-obUFG4F1+5Nm06d0sf49dFF9bkB_kUPFG1C4@xxxxxxxxxxxxxx> <1294152308.3831.290.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Sorry about that.  I had considered the whole series as one logical change, and broke it up by sets of directories to reduce the patch size and yet kept the changes local so that there aren't too many places to look when verifying that the patch went in correctly.  I admit that that ordering isn't the easiest to read through.

I'll refactor the chunks for both this series and the mem_access 2 series into more paired up units and resubmit them today.  It will be identical code, for anyone who has applied the ones already submitted, but will be in intermediately compilable patches.  The patches will end up being longer for that, so I hope that's okay.  The other alternative is one long patch, which I will attach in the alternative to my 0 of X email to make it easier to apply.


On Tue, Jan 4, 2011 at 6:45 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
I didn't review the whole series I just happened to notice this while
reviewing the use of hypercall buffers in libxc:

 On Wed, 2010-12-29 at 07:27 +0000, Joe Epstein wrote:
> +struct xen_hvm_set_mem_access {

The definition of this structure needs to come along with the first use
of it, which in this case would be the 1/5 patch which adds the

Similarly for any other interface changes etc. You need the code changes
to be with the interface changes, or otherwise to construct your patch
series such that you add the new interface, convert everything to it and
then remove the old interface.

Otherwise everything is broken mid-way through the series, it should
compile and work at each step/patch.

It also makes review hard since each patch doesn't really stand alone.


Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>