This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 3 of 5] mem_access: public interface changes

To: Joe Epstein <jepstein@xxxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 3 of 5] mem_access: public interface changes
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 4 Jan 2011 14:45:08 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 04 Jan 2011 06:45:59 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTim-obUFG4F1+5Nm06d0sf49dFF9bkB_kUPFG1C4@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <AANLkTim-obUFG4F1+5Nm06d0sf49dFF9bkB_kUPFG1C4@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
I didn't review the whole series I just happened to notice this while
reviewing the use of hypercall buffers in libxc:

 On Wed, 2010-12-29 at 07:27 +0000, Joe Epstein wrote:
> +struct xen_hvm_set_mem_access {

The definition of this structure needs to come along with the first use
of it, which in this case would be the 1/5 patch which adds the

Similarly for any other interface changes etc. You need the code changes
to be with the interface changes, or otherwise to construct your patch
series such that you add the new interface, convert everything to it and
then remove the old interface.

Otherwise everything is broken mid-way through the series, it should
compile and work at each step/patch.

It also makes review hard since each patch doesn't really stand alone.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>