 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH 3/5] vtdt: Modify vlapic code to add vtdt support
| To: | "Wei, Gang" <gang.wei@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH 3/5] vtdt: Modify vlapic code to add vtdt support |
| From: | Keir Fraser <keir@xxxxxxx> |
| Date: | Tue, 14 Dec 2010 08:48:51 +0000 |
| Cc: | Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx> |
| Delivery-date: | Tue, 14 Dec 2010 00:49:38 -0800 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=JMpquNjteywbtlyZkX3JyOX0pAuFz6CpZxlFiZThKLA=; b=KmYOGY0q++liw7CdB2aizhTk+LmnxPhk2VI3NQJuNEspumCMM2ogUYVmMNIIS/OTHY D8kE3p7iNCKB8IB6OsQpEAePscLKgdNKUW2rG9uvDPrQbQPXk2++fEAbGvEGqKM4EchW IwyhWUqB8DKTIHDJvdIdI2wvpsP+4U+CZsJgQ= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=gTslKK7voLQCDAZ4anktIdj5QKfM3MiIjgRUwb0+P//2GB/TA91FHw7y/CnotkC5SA YFqP/G4TTLKRR5kgCfqx0MZgrDBnHholFr9eIiqzo/ZghpX2WTyJ9RLh5JPyKIVftJdJ +936ojAINnnz4Xn3xm0eh4ShGdMjn6/3/v0jY= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <F26D193E20BBDC42A43B611D1BDEDE7124EADAFCDE@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcubPslPXD79XKNoRpanX8il5iAsXgAIq7U+AAF2X3AAARpTFg== |
| Thread-topic: | [Xen-devel] [PATCH 3/5] vtdt: Modify vlapic code to add vtdt support |
| User-agent: | Microsoft-Entourage/12.27.0.100910 |
On 14/12/2010 08:22, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
>>> @@ -265,6 +265,7 @@ struct hvm_hw_lapic {
>>> uint64_t apic_base_msr;
>>> uint32_t disabled; /* VLAPIC_xx_DISABLED */
>>> uint32_t timer_divisor;
>>> + uint64_t tdt_msr;
>>> };
>>
>> Is this backward compatible with old HVM save images?
>
> I am not sure about this. If it isn't, would you accept to simply add another
> data trunk for TDT msr?
That's Tim's call. I would personally prefer for Xen to accept truncated
chunks, and extend them with sensible 'old save image' defaults, such as
all-zeroes. That would be a generic solution to this case which will be
reusable in future, and avoid needlessly creating extra chunk types just for
backward compatibility reasons.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] iommu=0 leading to panic when system defaults to using x2apic, Weidong Han |
|---|---|
| Next by Date: | [Xen-devel] [PATCH] x86/iommu: account for necessary allocations when calculating Dom0's initial allocation size, Jan Beulich |
| Previous by Thread: | RE: [Xen-devel] [PATCH 3/5] vtdt: Modify vlapic code to add vtdt support, Wei, Gang |
| Next by Thread: | RE: [Xen-devel] [PATCH 3/5] vtdt: Modify vlapic code to add vtdt support, Wei, Gang |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
