Re: [Xen-devel] [PATCH V2 5/5] libxl: Lists qdisk device in libxl_device_disk_list

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Mon, 13 Dec 2010, anthony.perard@xxxxxxxxxx wrote:
> From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> 
> As libxl switch to qdisk when blktap isn't available, this patch makes
> libxl_device_disk_list also list qdisk device. So
> libxl_build_device_model_args_new will be able to add qdisk device to
> the command line options of Qemu.

This patch fails to compile:

libxl.c:2553:66: error: macro "strchr" requires 2 arguments, but only 1 given
cc1: warnings being treated as errors
libxl.c: In function ‘libxl_device_disk_list’:
libxl.c:2553: error: passing argument 1 of ‘strlen’ from incompatible pointer 
type
/usr/include/string.h:397: note: expected ‘const char *’ but argument is of 
type ‘char * (*)(const char *, int)’
libxl.c:2553: error: passing argument 1 of ‘__strdup’ from incompatible pointer 
type
/usr/include/bits/string2.h:1303: note: expected ‘const char *’ but argument is 
of type ‘char * (*)(const char *, int)’


I have applied patch 1, 2 and 4.
Next time please add an explicit signed-off-by line to your patches.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel