WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] wrong vmexit size in xenalyze

To: Olaf Hering <olaf@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] wrong vmexit size in xenalyze
From: Keir Fraser <keir@xxxxxxx>
Date: Fri, 19 Nov 2010 09:34:57 +0000
Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
Delivery-date: Fri, 19 Nov 2010 01:36:28 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=gIyjQP2BD9OyR2BvJsaMXSoia06Y9FewGMLnqtguXFw=; b=aXPsw5OR40EIrW2GXGm2KEQvM8dzyAVFeNqB/xK2VFFQVvx/m5PpvWD62xArsUNGFf EwAjy3in1AIVJH6LltYfMwV274l1+Kg+EO+1qAHjO4jxFFRSJQGnWoodN0Jv10Qru6Rv FAbqdpiYu9TMqpYgq+9cUUwzOc2iTCaJbFy/4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=A0uRu9TNgmgIjAIPCwcHGWe+KvH2i/3idClUcX0DakpNBpP0KXlnzMCeKEeN8IFRIM Ry2/PYqdEGju8F/hCrOhGqaRRv4FBErMeYxDDUT2qL6DfZLew7CdQFsqs0cnZBhF5END SgRPfaoNXlhmm5x9j9xgVAQd6xmp9fK7kiXek=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101119092317.GA1755@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcuHzQdBZ06mLYKDTku/ZgJ8x2/EzQ==
Thread-topic: [Xen-devel] wrong vmexit size in xenalyze
User-agent: Microsoft-Entourage/12.27.0.100910
Xenalyze should do a Xen version check and do the appropriate thing for 4.0
and earlier versus 4.1 and later. Changing visible behaviour of a Xen stable
branch will just add to the confusion.

 -- Keir

On 19/11/2010 09:23, "Olaf Hering" <olaf@xxxxxxxxx> wrote:

> George,
> 
> what is the reason behind this changeset?
> http://xenbits.xensource.com/ext/xenalyze.hg?rev/9fa7e4d2a3af
> 
> All my vmexit trace entries have size 4 for 64bit and 3 for 32bit.
> Looking at the code in ./xen/arch/x86/hvm/vmx/vmx.c, HVMTRACE_ND() gets
> size 3 for VMEXIT64. But HVMTRACE_ND does a 'sizeof(u32)*count+1' in
> xen-4.0. 
> The xen-unstable macro looks different. It was changed in this revision:
> 
>  # 8 weeks ago:    x86/hvm: fix extra size passed to __trace_var()
>  # revision 10:    9cebb977e9d8 (diff) (annotate)
>  # author:         Keir Fraser <keir.fraser@xxxxxxxxxx>
>  # date:   Mon Sep 20 18:53:18 2010 +0100
> 
> I think this means most of the extra_words checks are bogus now, unless
> the same change also goes into the 4.0 branch.
> 
> What should we do about this difference in tracedata?
> 
> 
> Olaf
> 
> --- a/xenalyze.c        Wed Nov 10 14:56:56 2010 +0000
> +++ b/xenalyze.c        Wed Nov 10 14:58:31 2010 +0000
> @@ -4828,8 +4828,8 @@ void hvm_vmexit_process(struct record_in
>          };
>      } *r;
>  
> -    if(ri->extra_words != 4
> -       && ri->extra_words != 3
> +    if(ri->extra_words != 3
> +       && ri->extra_words != 2
>          )
>      {
>          fprintf(warn, "FATAL: vmexit has unexpected extra words %d!\n",
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel