This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: [RFC][PATCH][VTD][v4] consolidate VT-d quirks into a si

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: [Xen-devel] RE: [RFC][PATCH][VTD][v4] consolidate VT-d quirks into a single file quirks.c
From: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Date: Thu, 28 Oct 2010 08:50:05 -0700
Accept-language: en-US
Acceptlanguage: en-US
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 28 Oct 2010 08:51:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CC93AE6020000780001FA24@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <987664A83D2D224EAE907B061CE93D5301643A8DC7@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4CB6E3BC020000780001D1B6@xxxxxxxxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D530164421B79@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4CB83149020000780001D47E@xxxxxxxxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D53016468D1E2@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4CC93AE6020000780001FA24@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Act2bV7SGWjfgjLxR2a2KASWtsW0VgASbBAQ
Thread-topic: [RFC][PATCH][VTD][v4] consolidate VT-d quirks into a single file quirks.c
> Yes, this looks better now. However, map_igd_reg() now returns
> "status" without ever initializing the variable. Didn't the compiler
> warn (and the build fail because) of that? I think the function has
> no need to return non-void anymore.

I just did a build again, the compiler come with FC12 did not complain about it 
at all.  I have changed the function to void.

> The non-void return value of cantiga_vtd_ops_preamble() also
> looks bogus, btw.

The return value is not important in this case.  It is the requirement of the 
errata workaround to read the MMIO register.

> One thing I may not have noticed in earlier versions is your use
> of IGD_BAR_MASK - you define it as 0xFFFF0000 but then use
> it to mask a 64-bit value (i.e. cutting of the top 32 bits).


See attached for version 4.


Attachment: quirks1028.patch
Description: quirks1028.patch

Xen-devel mailing list