This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: [RFC][PATCH][VTD][v3] consolidate VT-d quirks into a si

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: [Xen-devel] RE: [RFC][PATCH][VTD][v3] consolidate VT-d quirks into a single file quirks.c
From: "Kay, Allen M" <allen.m.kay@xxxxxxxxx>
Date: Wed, 27 Oct 2010 15:29:17 -0700
Accept-language: en-US
Acceptlanguage: en-US
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 27 Oct 2010 15:30:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CB83149020000780001D47E@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <987664A83D2D224EAE907B061CE93D5301643A8DC7@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4CB6E3BC020000780001D1B6@xxxxxxxxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D530164421B79@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4CB83149020000780001D47E@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: ActsRaAOoCaDhvLXQ/mfv/yeSI9PyAJ3neTw
Thread-topic: [RFC][PATCH][VTD][v3] consolidate VT-d quirks into a single file quirks.c
Jan, sorry disappearing for the last week.  I had to attend to some urgent 

> The issue is not with doing a mapping, but with where (in virtual address 
> space)
> you map to: You're passing a *physical* address for what is to be a *virtual* 
> one
> (first argument to map_pages_to_xen()), i.e. as soon as there is any domain 
> the
> mapping will conflict with the domain's use of virtual addresses.

Agree.  I fixed it in the attached v3 patch by using a fixmap entry for doing 

> There's one more thing I just noticed: Isn't warning you're
> adding to is_igd_drhd() going to trigger needlessly (and perhaps
> frequently) on Intel IOMMU systems without any device at 0:2.0
> I think if at all, the warning should only be issued once.

I removed the warning message.


Attachment: quirks10272.patch
Description: quirks10272.patch

Xen-devel mailing list