This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xen: do not unmask disabled IRQ on eoi.

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: do not unmask disabled IRQ on eoi.
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Fri, 22 Oct 2010 13:04:24 +0100
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "jeremy@xxxxxxxx" <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 22 Oct 2010 05:06:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CC15C5B020000780001E8B2@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1287139966-19391-2-git-send-email-ian.campbell@xxxxxxxxxx> <alpine.DEB.2.00.1010151614420.2423@kaball-desktop> <1287160335.2003.7973.camel@xxxxxxxxxxxxxxxxxxxxxx> <1287160787.2003.7979.camel@xxxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1010151757240.2423@kaball-desktop> <4CBC1CF1020000780001DA3F@xxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1010181530200.2423@kaball-desktop> <4CBC80E6020000780001DC78@xxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1010181754180.2423@kaball-desktop> <4CBD5883020000780001DEC4@xxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1010211411100.10348@kaball-desktop> <4CC15C5B020000780001E8B2@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Fri, 22 Oct 2010, Jan Beulich wrote:
> >>> On 21.10.10 at 15:36, Stefano Stabellini 
> >>> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > New version of this patch:
> Looks consistent now, with one possible exception (I'm not sure here
> really). I'm not going to ack this nevertheless as I continue to not be
> convinced of the switch to handle_edge_irq(), the more that your
> patch (as you write yourself) complicates the code.

In general I am always for the simplest solution, however in this case
it is not only a matter of simplicity but also a matter of correctness
and integration with the rest of linux irq handling infrastructure.

Obviously if something in this patch is inconsistent we could get less
correct and more complicated code so thanks for helping out making sure
it is consistent! If you find any more flaws please let me know :)

Xen-devel mailing list