This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 2 of 3] support of cpupools in xl: commands and l

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 3] support of cpupools in xl: commands and library changes
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 12 Oct 2010 10:59:31 +0100
Cc: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 12 Oct 2010 03:01:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19636.12203.651041.734393@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <patchbomb.1286536982@nehalem1> <91397dcffead19270897.1286536984@nehalem1> <19636.12203.651041.734393@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2010-10-12 at 10:51 +0100, Ian Jackson wrote:
> Juergen Gross writes ("[Xen-devel] [PATCH 2 of 3] support of cpupools in xl: 
> commands and library changes"):
> > tools/libxl/libxlu_cfg_l.c   |   30 --
> > tools/libxl/libxlu_cfg_l.h   |   18 -
> I see you reran flex.  That's not wrong, but we shouldn't change these
> files needlessly, and you didn't make any changes to the .l source
> file, so when we apply this patch we should drop the changes to
> *_l.[ch].
> > Renamed all cpu pool related names to *cpupool*
> Is that really true in this patch ?  The function names and subcommand
> names in xl are still all "pool-*" and "pool_*".

The subcommands names are the xm names, which I thought we needed to
keep for compatibility.

We could add both cpupool- and pool- variants and deprecate the later.
Or perhaps these commands are not widely used (at least from scripts and
whatnot) and we can just change the name.

See <4CAB2CE5.1070208@xxxxxxxxxxxxxx> and
<1286371053.23155.12762.camel@xxxxxxxxxxxxxxxxxxxxxx> for some previous


Xen-devel mailing list