Re: [Xen-devel] [PATCH 2 of 3] support of cpupools in xl: comman

To:	Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 2 of 3] support of cpupools in xl: commands and library changes
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Tue, 12 Oct 2010 11:56:56 +0200
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Tue, 12 Oct 2010 02:59:06 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1286877420; x=1318413420; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; z=Message-ID:=20<4CB430E8.4040004@xxxxxxxxxxxxxx>\|Date:=20 Tue,=2012=20Oct=202010=2011:56:56=20+0200\|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>\|MIME-Version: =201.0\|To:=20Ian=20Jackson=20<Ian.Jackson@xxxxxxxxxxxxx> \|CC:=20xen-devel@xxxxxxxxxxxxxxxxxxx\|Subject:=20Re:=20[Xe n-devel]=20[PATCH=202=20of=203]=20support=20of=20cpupools =20in=20xl:=20commands=0D=0A=20and=09library=20changes \|References:=20<patchbomb.1286536982@nehalem1>=09<91397dc ffead19270897.1286536984@nehalem1>=20<19636.12203.651041. 734393@xxxxxxxxxxxxxxxxxxxxxxxx>\|In-Reply-To:=20<19636.12 203.651041.734393@xxxxxxxxxxxxxxxxxxxxxxxx> \|Content-Transfer-Encoding:=207bit; bh=Ob/SMlPfPEqom0YHOyB1AG/4AifRYDGfrzZJzkAb44k=; b=mMSmImaVhqkWmgJmxq4qtKPeqEFv0ELI3nMrbXyY6QTB9xB0iLecXxlc 0AGeDn9hQEgLqwp49lM55Aipidyc+24MYZ2o/Hb7eqxaAGlZKIayHXMTJ upplK0VbBFRPMuGJ7RMW8sJ7q6fzNsi5XEBWD8FiohDpSGr/zq7fvuiaU qQg5Vt39fr6tQjSh/9ikQ83umbkBAQgyvbMRGZf4pYW3V7dIAZFSFS3w5 kLBUaWisDOMgL2H50fuhIWF40I0dR;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=jFXY20TFjfEAMrNnDn+EHAcGHxq3/5I8MVLsRQUR258+tKZTsk6p2cag tGWu00uAArTg5OMpN/mOMPpEid1iSTzl62H9CUI1zRQY8n70SBzYRMj7s qtexB8GykHbQiX0Mu9tTnkt0gNoo4yOK1kjuu0MkfNsTQuxtM7u6qpAVB xac3GtiLUh5SmpS3ixLWjtAN9It5ENOGrG37yFtOjTuj+cBZVg1crtt77 +wQjgy48u3mWvaz+ejjNM/zHPDYsY;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<19636.12203.651041.734393@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
References:	<patchbomb.1286536982@nehalem1> <91397dcffead19270897.1286536984@nehalem1> <19636.12203.651041.734393@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100913 Iceowl/1.0b1 Icedove/3.0.7

On 10/12/10 11:51, Ian Jackson wrote:

Juergen Gross writes ("[Xen-devel] [PATCH 2 of 3] support of cpupools in xl: 
commands and library changes"):

tools/libxl/libxlu_cfg_l.c   |   30 --
tools/libxl/libxlu_cfg_l.h   |   18 -


I see you reran flex.  That's not wrong, but we shouldn't change these
files needlessly, and you didn't make any changes to the .l source
file, so when we apply this patch we should drop the changes to
*_l.[ch].


I excluded these changes once before and was told they should be included...
I didn't call flex manually, this was done by make.

Renamed all cpu pool related names to *cpupool*


Is that really true in this patch ?  The function names and subcommand
names in xl are still all "pool-*" and "pool_*".


There was no response to the question whether to change the sub-command names
or not. And I think the sub-command functions should reflect the names.


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 2 of 3] support of cpupools in xl: commands and l