This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH 15/22] x86: Copy-n-paste arch_teardown_msi_irqs f

To: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 15/22] x86: Copy-n-paste arch_teardown_msi_irqs from msi.c to io_apic.c.
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Wed, 6 Oct 2010 22:57:50 -0400
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>
Delivery-date: Wed, 06 Oct 2010 20:03:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101007010913.GA22093@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1286216015-9710-1-git-send-email-konrad.wilk@xxxxxxxxxx> <1286216015-9710-16-git-send-email-konrad.wilk@xxxxxxxxxx> <alpine.LFD.2.00.1010051055470.2556@xxxxxxxxxxxxxxxxxxxxxxx> <20101007010913.GA22093@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Oct 06, 2010 at 09:09:13PM -0400, Konrad Rzeszutek Wilk wrote:
> On Tue, Oct 05, 2010 at 11:07:36AM +0200, Thomas Gleixner wrote:
> > On Mon, 4 Oct 2010, Konrad Rzeszutek Wilk wrote:
> > 
> > > In preparation for non-privileged domains to disable PCI devices'
> > > MSI/MSIx, we need to augment arch_teardown_msi_irqs to make
> > > a call to the privileged domain (patch to follow).
> > 
> > Can't we find a more clever solution than just copying stuff around ?
> Thanks for suggestion. Based on your idea, this is the patch I've rigged up.
> I've also included a different re-implementation of the next patch
> that would utilize this (x86-Introduce-x86_msi_ops). Tested successfully on 
> x86.
> Cross-compiling on PPC, PPC64, and IA64 shows no failure.

But I did find that playing with 'make randconfig' where I got:
# CONFIG_PCI not set

produces interesting errors. So attached is the second patch, but
hardned against the case of building an X86 kernel without PCI support.

The patches are also available at:

Attachment: 0001-x86-Introduce-x86_msi_ops.patch
Description: Text Data

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>