This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Re: xen: PV on HVM: support PV spinlocks

To: Josip Rodin <joy@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: xen: PV on HVM: support PV spinlocks
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Mon, 4 Oct 2010 14:29:39 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 04 Oct 2010 06:31:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20101002112634.GA19884@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20101002112634.GA19884@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Sat, 2 Oct 2010, Josip Rodin wrote:
> Hi,
> I was just reading
> http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=commitdiff;h=a16a1a93b92ef09c4d759fc711c7f17b658176ec
> And there's a chunk that says:
> +static void xen_hvm_spinlock_init(void)
> +{
> +       if (!xen_have_vector_callback)
> +               return
> +       xen_init_lock_cpu(0);
> +       xen_init_spinlocks();
> +}
> The return statement doesn't have a semicolon after it, so it will instead
> take xen_init_lock_cpu(0) as its argument, and the xen_init_spinlocks() call
> will never happen.

Well spotted!!  I fixed this issue (and another spinlock initialization
problem I found after that) and force-pushed both 2.6.32-pvhvm
and 2.6.35-rc5-pvhvm-v7.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>