 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] Re: xen: PV on HVM: support PV spinlocks
| To: | xen-devel@xxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | [Xen-devel] Re: xen: PV on HVM: support PV spinlocks |
| From: | Josip Rodin <joy@xxxxxxxxxxxxxx> |
| Date: | Sat, 2 Oct 2010 13:26:34 +0200 |
| Delivery-date: | Sat, 02 Oct 2010 04:27:33 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| User-agent: | Mutt/1.5.18 (2008-05-17) |
Hi, I was just reading http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=commitdiff;h=a16a1a93b92ef09c4d759fc711c7f17b658176ec And there's a chunk that says: +static void xen_hvm_spinlock_init(void) +{ + if (!xen_have_vector_callback) + return + xen_init_lock_cpu(0); + xen_init_spinlocks(); +} The return statement doesn't have a semicolon after it, so it will instead take xen_init_lock_cpu(0) as its argument, and the xen_init_spinlocks() call will never happen. -- 2. That which causes joy or happiness. _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [xen-4.0-testing test] 2299: regressions - FAIL, xen . org |
|---|---|
| Next by Date: | [Xen-devel] Migrated domUs hangs, Cédric Schieli |
| Previous by Thread: | [Xen-devel] [xen-4.0-testing test] 2299: regressions - FAIL, xen . org |
| Next by Thread: | Re: [Xen-devel] Re: xen: PV on HVM: support PV spinlocks, Stefano Stabellini |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
