 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH 0/3 v2] XSAVE/XRSTOR fixes and enhancements
| To: | Weidong Han <weidong.han@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH 0/3 v2] XSAVE/XRSTOR fixes and enhancements |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Wed, 1 Sep 2010 09:09:42 +0100 |
| Cc: | Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx> |
| Delivery-date: | Wed, 01 Sep 2010 01:10:19 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4C7E0738.3070405@xxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | ActJqzYa34aawAUJTRK0dnhqK1xVrwAAdG8V |
| Thread-topic: | [Xen-devel] [PATCH 0/3 v2] XSAVE/XRSTOR fixes and enhancements |
| User-agent: | Microsoft-Entourage/12.26.0.100708 |
On 01/09/2010 08:56, "Weidong Han" <weidong.han@xxxxxxxxx> wrote: >> Well that's how it was explained to me at the time. Was that in fact wrong >> and we are already broken for save/restore for some subtle unexplained >> reason? >> > > When XSAVE is enabled, it saves states to xsave_area in struct hvm_vcpu. > But hvm_save_cpu_ctxt and hvm_load_cpu_ctxt don't save/restore FPU/SSE > from xsave_area. So FPU/SSE states are incorrect after guest save/restore. Ignoring AVX, that needs fixing in 4.0 branch. The state needs pulling out of the xsave area and into the existing hvm_hw_cpu structure. Or, we disable xsave by default on 4.0.x branch. What do you think? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: [Xen-devel] Xen-unstable panic: FATAL PAGE FAULT, Jan Beulich |
|---|---|
| Next by Date: | [Xen-devel] [PATCh]: Fix too early restart in case core dump active, Miroslav Rezanina |
| Previous by Thread: | Re: [Xen-devel] [PATCH 0/3 v2] XSAVE/XRSTOR fixes and enhancements, Weidong Han |
| Next by Thread: | Re: [Xen-devel] [PATCH 0/3 v2] XSAVE/XRSTOR fixes and enhancements, Weidong Han |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
