WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0/3 v2] XSAVE/XRSTOR fixes and enhancements

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/3 v2] XSAVE/XRSTOR fixes and enhancements
From: Weidong Han <weidong.han@xxxxxxxxx>
Date: Wed, 01 Sep 2010 15:56:40 +0800
Cc: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Wed, 01 Sep 2010 00:59:59 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C8A3C1C3.219D0%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C8A3C1C3.219D0%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.21 (Windows/20090302)
Keir Fraser wrote:
On 01/09/2010 08:26, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

Yes. As I said in another email, actually it already breaks hvm guests
save/restore on platforms which supports XSAVE/XRSTOR.
Wow, so the last couple of Xen releases are broken for the latest Intel
platforms unless you specify no-xsave. Handy to know I guess.

Actually, hang on, Dexuan's patch only enabled XSAVE of FPU/SSE and didn't
make any other new state visible. We already save/restore FPU/SSE of course,
so I don't see why the code we already have is broken for HVM save/restore.
It's the adding of new state that we don't s/r that would be broken --- like
your patch to make AVX visible.

Well that's how it was explained to me at the time. Was that in fact wrong
and we are already broken for save/restore for some subtle unexplained
reason?

When XSAVE is enabled, it saves states to xsave_area in struct hvm_vcpu. But hvm_save_cpu_ctxt and hvm_load_cpu_ctxt don't save/restore FPU/SSE from xsave_area. So FPU/SSE states are incorrect after guest save/restore.

Regards,
Weidong
 -- Keir

Why is the feature flag stuff all stuffed in Xen itself rather than
xc_cpuid_x86.c, by the way? Shouldn't your change also be in the same place,
or (much preferably) all XSAVE related stuff be moved out into
libxc/xc_cpuid_x86.c?




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel