[Xen-devel] Re: [PATCH 1/3] xen: pvhvm: allow user to request no emulated device unplug

[Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>]

On Thu, 2010-08-19 at 11:37 +0100, Stefano Stabellini wrote:
> On Thu, 19 Aug 2010, Ian Campbell wrote:
> >     if (r && !(r == XEN_PLATFORM_ERR_MAGIC &&
> > +                   (xen_emul_unplug != -1) &&
> >                     (xen_emul_unplug & XEN_UNPLUG_IGNORE)))
> 
> I wouldn't add xen_emul_unplug != -1 because it should be clear that
> xen_emul_unplug & XEN_UNPLUG_IGNORE always implies xen_emul_unplug != -1.

That's not correct since -1 is all 1s. So you can get a false positive
for "xen_emul_unplug & XEN_UNPLUG_IGNORE" if xen_emul_unplug == -1.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel