This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH 1/3] xen: pvhvm: allow user to request no emulate

To: Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 1/3] xen: pvhvm: allow user to request no emulated device unplug
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Thu, 19 Aug 2010 11:50:07 +0100
Cc: Fitzhardinge <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jeremy
Delivery-date: Thu, 19 Aug 2010 03:50:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <alpine.DEB.2.00.1008191132250.2545@kaball-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1282211932.3170.2341.camel@xxxxxxxxxxxxxxxxxxxxxx> <1282211946-8629-1-git-send-email-ian.campbell@xxxxxxxxxx> <alpine.DEB.2.00.1008191132250.2545@kaball-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2010-08-19 at 11:37 +0100, Stefano Stabellini wrote:
> On Thu, 19 Aug 2010, Ian Campbell wrote:
> >     if (r && !(r == XEN_PLATFORM_ERR_MAGIC &&
> > +                   (xen_emul_unplug != -1) &&
> >                     (xen_emul_unplug & XEN_UNPLUG_IGNORE)))
> I wouldn't add xen_emul_unplug != -1 because it should be clear that
> xen_emul_unplug & XEN_UNPLUG_IGNORE always implies xen_emul_unplug != -1.

That's not correct since -1 is all 1s. So you can get a false positive
for "xen_emul_unplug & XEN_UNPLUG_IGNORE" if xen_emul_unplug == -1.


Xen-devel mailing list